This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add Axpy_batch implementation #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-Nick
requested review from
muhammad-tanvir-1211,
pgorlani,
OuadiElfarouki and
aacostadiaz
s-Nick
force-pushed
the
axpy_batch_impl
branch
from
2ddf10a to
0ccfe3e
Compare
OuadiElfarouki
approved these changes
Nov 20, 2023
muhammad-tanvir-1211
approved these changes
Nov 22, 2023
| value_t eval(index_t i); | ||
| value_t eval(cl::sycl::nd_item<1> ndItem); | ||
| template <typename sharedT> | ||
| value_t eval(sharedT shMem, cl::sycl::nd_item<1> ndItem); |
There was a problem hiding this comment.
We don't define eval function with shared memory so I think it's best to remove this declaration from the class.
There was a problem hiding this comment.
Thank you for the review @muhammad-tanvir-1211. I removed these two functions in 33621a5
muhammad-tanvir-1211
merged commit a6d044a
into
codeplaysoftware:master
3 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation for extension operator
axpy_batch. It adds tests and benchmark for available platforms.